tvalentyn commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r613566512



##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -502,6 +505,8 @@ def run(self, test_runner_api='AUTO'):
     # Records whether this pipeline contains any cross-language transforms.
     self.contains_external_transforms = (
         ExternalTransformFinder.contains_external_transforms(self))
+    # Move in to_runner_api instead?

Review comment:
       I think 
https://github.com/apache/beam/pull/14390/commits/5d58030998e77c066881891b94e4056c4778122a
 would take care of it? But if you think it's too risky, I can punt this commit 
for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to