pabloem commented on a change in pull request #14517:
URL: https://github.com/apache/beam/pull/14517#discussion_r613638935
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1393,9 +1430,16 @@ def fill_dataframe(*args):
- cummax = cummin = cumsum = cumprod = frame_base.wont_implement_method(
- 'order-sensitive')
- diff = frame_base.wont_implement_method('order-sensitive')
+ cummax = frame_base.order_sensitive_method(pd.DataFrame, 'cummax')
+ cummin = frame_base.order_sensitive_method(pd.DataFrame, 'cummin')
+ cumprod = frame_base.order_sensitive_method(pd.DataFrame, 'cumprod')
+ cumsum = frame_base.order_sensitive_method(pd.DataFrame, 'cumsum')
+ diff = frame_base.order_sensitive_method(pd.DataFrame, 'diff')
Review comment:
hmmm I see... I was thinking that you would do `index = index - 1` on
the DF, and then operate the result against the original DF, but this is not
possible because indices are not necessarily integers, and may not be sorted
integers either, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
