elharo commented on a change in pull request #14527:
URL: https://github.com/apache/beam/pull/14527#discussion_r613980011
##########
File path:
sdks/java/extensions/google-cloud-platform-core/src/test/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilTest.java
##########
@@ -502,7 +502,9 @@ public void testGetSizeBytesWhenFileNotFoundBatchRetry()
throws Exception {
// 429: Too many requests, then 200: OK.
when(mockResponse.getStatusCode()).thenReturn(429, 200);
- when(mockResponse.getContent()).thenReturn(toStream("error"),
toStream(content));
+ // Google-http-client:1.39.1 and above does not read content stream of the
error response.
Review comment:
This should not be true unless disconnect is being called somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
