anupd22 commented on a change in pull request #14534:
URL: https://github.com/apache/beam/pull/14534#discussion_r614622683
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/CalciteUtils.java
##########
@@ -280,7 +280,8 @@ private static RelDataType toRelDataType(
/**
* SQL-Java type mapping, with specified Beam rules: <br>
* 1. redirect {@link AbstractInstant} to {@link Date} so Calcite can
recognize it. <br>
- * 2. For a list, the component type is needed to create a Sql array type.
+ * 2. For a list, the component type is needed to create a Sql array type.
3. For a Map, the
Review comment:
Hi @ibzib ,
Added two unit tests.
[1] Udaf that squares each input(1,2,3,4) and returns them in a List [1 4 9
16]
[2] Udaf that squares each input(1,2,3,4) and returns them in a Map
{"squareOf-1":1,"squareOf-2":4,"squareOf-3":9,"squareOf-4":16}
Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
