KevinGG commented on pull request #14558: URL: https://github.com/apache/beam/pull/14558#issuecomment-821325669
> IIUC this PR does two things: > > 1. Make `shutil.rmtree` handle failures gracefully by warning the user > 2. Adjust `recording_manager_test` to avoid a situation that can cause an `shutil.rmtree` error > > Is that correct? > > (1) LGTM. I'm not very familiar with the code for (2) though, would appreciate a review from @rohdesamuel on that. That's correct. Thanks for the review, I'll wait for Sam's review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
