MaksymSkorupskyi commented on a change in pull request #14460: URL: https://github.com/apache/beam/pull/14460#discussion_r615879307
########## File path: sdks/python/apache_beam/io/mongodbio.py ########## @@ -66,542 +66,771 @@ # pytype: skip-file +import codecs import itertools import json import logging import math import struct +from typing import Union + +from bson import json_util +from bson.objectid import ObjectId import apache_beam as beam from apache_beam.io import iobase from apache_beam.io.range_trackers import OrderedPositionRangeTracker -from apache_beam.transforms import DoFn -from apache_beam.transforms import PTransform -from apache_beam.transforms import Reshuffle +from apache_beam.transforms import DoFn, PTransform, Reshuffle from apache_beam.utils.annotations import experimental _LOGGER = logging.getLogger(__name__) try: - # Mongodb has its own bundled bson, which is not compatible with bson pakcage. - # (https://github.com/py-bson/bson/issues/82). Try to import objectid and if - # it fails because bson package is installed, MongoDB IO will not work but at - # least rest of the SDK will work. - from bson import objectid - - # pymongo also internally depends on bson. - from pymongo import ASCENDING - from pymongo import DESCENDING - from pymongo import MongoClient - from pymongo import ReplaceOne + # Mongodb has its own bundled bson, which is not compatible with bson pakcage. Review comment: reformatted, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
