tvalentyn commented on a change in pull request #14390:
URL: https://github.com/apache/beam/pull/14390#discussion_r616082415
##########
File path: sdks/python/apache_beam/runners/pipeline_context.py
##########
@@ -118,13 +120,19 @@ def get_by_id(self, id):
def get_by_proto(self, maybe_new_proto, label=None, deduplicate=False):
# type: (message.Message, Optional[str], bool) -> str
+ obj = self._obj_type.from_runner_api(
Review comment:
There is bug - note how we used to assign a label to a field that's
actually 'obj'. Commit that made this change: [`0b42ca9`
(#14390)](https://github.com/apache/beam/pull/14390/commits/0b42ca9eed47794586b5751c183cd66be8b5e8a7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
