suztomo commented on a change in pull request #14578:
URL: https://github.com/apache/beam/pull/14578#discussion_r616883963
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/Uuid.java
##########
@@ -49,6 +50,9 @@ public static Uuid random() {
} catch (IOException e) {
throw new RuntimeException("Should never have an IOException since there
is no io.", e);
}
- return Uuid.of(output.toByteString());
+ // Encode to Base64 so the random UUIDs are valid if consumed from the
Cloud Pub/Sub client.
+ return Uuid.of(
+ ByteString.copyFrom(
+
Base64.getEncoder().encode(output.toByteString().asReadOnlyByteBuffer())));
Review comment:
This change comes from
https://github.com/googleapis/java-pubsublite/pull/552/files
CC: @dpcollins-google
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/SubscribeTransform.java
##########
@@ -44,8 +44,6 @@
import org.joda.time.Duration;
class SubscribeTransform extends PTransform<PBegin,
PCollection<SequencedMessage>> {
- private static final Duration MAX_SLEEP_TIME = Duration.standardMinutes(1);
Review comment:
This change comes from
https://github.com/googleapis/java-pubsublite/pull/552/files
CC: @dpcollins-google
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
