ibzib commented on a change in pull request #14588:
URL: https://github.com/apache/beam/pull/14588#discussion_r617764115
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/BeamZetaSqlCatalog.java
##########
@@ -379,6 +391,16 @@ private void addUdfsFromSchema() {
}
}
+ private List<FunctionArgumentType> getArgumentTypes(
Review comment:
Never mind, the order did matter here, since we need to validate scalar
parameter types before converting them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
