emilymye commented on a change in pull request #14575:
URL: https://github.com/apache/beam/pull/14575#discussion_r617937518
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineWorkerPoolOptions.java
##########
@@ -112,30 +108,30 @@ public String getAlgorithm() {
void setDiskSizeGb(int value);
- /**
- * Docker container image that executes Dataflow worker harness, residing in
Google Container
- * Registry.
- */
- @Default.InstanceFactory(WorkerHarnessContainerImageFactory.class)
+ /** Container image used as Dataflow worker harness image. */
+ /** @deprecated Use {@link #getSdkContainerImage} instead. */
@Description(
- "Docker container image that executes Dataflow worker harness, residing
in Google "
- + " Container Registry.")
+ "Container image used to configure a Dataflow worker. "
+ + "Can only be used for official Dataflow container images.")
+ @Deprecated
@Hidden
String getWorkerHarnessContainerImage();
+ /** @deprecated Use {@link #setSdkContainerImage} instead. */
+ @Deprecated
+ @Hidden
void setWorkerHarnessContainerImage(String value);
/**
- * Returns the default Docker container image that executes Dataflow worker
harness, residing in
- * Google Container Registry.
+ * Container image used to configure SDK execution environment on worker,
refered to as the SDK
+ * harness image.
*/
- class WorkerHarnessContainerImageFactory implements
DefaultValueFactory<String> {
Review comment:
Now, the value of either option may return null when the default image
is being used. I think this is an acceptable "breaking" change since the
returned URL is not usable as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
