kennknowles commented on pull request #14641:
URL: https://github.com/apache/beam/pull/14641#issuecomment-826460319


   R: @chamikaramj and @ihji since you are 2.30.0 release manager and this 
helps to fix for 2.30.0.
   
   Please review even though there are some final things. I have run enough 
tests I don't want to rebase or change the commit history right now.
   
    - I will drop the logging commit.
    - I will keep the new test cases, which are good for getting quick feedback 
without running a job.
    - There is another commit that sickbays a test because the test has some 
hardcoded coder that has changed. All the `ViewTest` passed when I ran locally 
so I think side inputs work. The test that I disabled was complex enough that I 
did not know how to fix it or if it was truly necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to