lostluck commented on a change in pull request #14678:
URL: https://github.com/apache/beam/pull/14678#discussion_r623187723



##########
File path: sdks/go/README.md
##########
@@ -156,8 +156,9 @@ are added in a PR then the lock file needs to be updated.
 From the `$GOPATH/src/github.com/apache/beam` directory run
 
 ```
+$ ./gradlew :sdks:go:goVendor
 $ ./gradlew :sdks:go:goLock
-`./gradlew :goPostcommit`
+$ ./gradlew :goPostcommit

Review comment:
       We should probably change this to run the portable precommit test suite 
instead of the Dataflow using one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to