TheNeuralBit commented on a change in pull request #14686:
URL: https://github.com/apache/beam/pull/14686#discussion_r623250043
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/utils/AvroUtilsTest.java
##########
@@ -213,7 +213,7 @@ public void testNullableBeamArrayFieldToAvroField() {
fields.add(
new org.apache.avro.Schema.Field(
"decimal",
- LogicalTypes.decimal(Integer.MAX_VALUE)
Review comment:
@reuvenlax this change actually breaks `testFromBeamSchema`, because we
cannot generate the correct Avro schema from the Beam schema (it doesn't have
fixed precision/scale). What do you think about skipping
`testFromBeamSchema`until we can fix it more durably (e.g. by adding a fixed
decimal logical type to map to)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
