TheNeuralBit commented on a change in pull request #14689:
URL: https://github.com/apache/beam/pull/14689#discussion_r623394660
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -711,6 +711,7 @@ def test_top_level(self):
wont_implement_ok={
'to_datetime': ['s.head()'],
'to_pickle': ['*'],
+ 'melt': ['*'],
Review comment:
similarly here, but based on [these
examples](https://pandas.pydata.org/docs/reference/api/pandas.melt.html)
##########
File path: sdks/python/apache_beam/dataframe/pandas_doctests_test.py
##########
@@ -208,10 +208,10 @@ def test_dataframe_tests(self):
],
'pandas.core.frame.DataFrame.sort_index': ['*'],
'pandas.core.frame.DataFrame.sort_values': ['*'],
+ 'pandas.core.frame.DataFrame.melt': ['*']
Review comment:
Could you modify this so it just skips the calls that don't work?
Unfortunately that will be most of them, since the defiault is
`ignore_index=True`, but based on
https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.melt.html it
looks like we can at least run `df.melt(id_vars=['A'], value_vars=['B', 'C'],
ignore_index=False)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
