Amar3tto commented on pull request #14273: URL: https://github.com/apache/beam/pull/14273#issuecomment-830129312
Hello @pabloem, @TheNeuralBit, thank you for your review. For now, I'm trying to implement such features as `into()` and `exceptionsVia()`. I found that in the `MapElements` class there a lot of code that needs to be moved to `MapValues` and `MapKeys` classes as well. For example, to implement `exceptionsVia()` in the `MapValues` class, we need to have `MapValuesWithFailures` nested class. Is it ok that `MapElements`, `MapValues`, and `MapKeys` classes will have a similar code? Maybe you can suggest some other ideas with the inheritance I might miss? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
