udim commented on a change in pull request #14716:
URL: https://github.com/apache/beam/pull/14716#discussion_r626793908
##########
File path: sdks/python/container/run_validatescontainer.sh
##########
@@ -118,14 +118,13 @@ SDK_LOCATION=$2
# Run ValidatesRunner tests on Google Cloud Dataflow service
echo ">>> RUNNING DATAFLOW RUNNER VALIDATESCONTAINER TEST"
-python setup.py nosetests \
- --attr ValidatesContainer \
- --nologcapture \
- --processes=1 \
- --process-timeout=900 \
- --with-xunitmp \
- --xunitmp-file=$XUNIT_FILE \
- --ignore-files '.*py3\d?\.py$' \
+pytest -o junit_suite_name=$IMAGE_NAME \
+ -m="it_validatescontainer" \
+ --no-print-logs \
Review comment:
I was also trying out `--log-cli-level=INFO` a few weeks back, if you
could add that. I liked that it printed out the test names and pass/fail/skip
status. (normally it also logs test output, but with --numprocesses=N that's
not the case so it's not spammy)
##########
File path: sdks/python/container/run_validatescontainer.sh
##########
@@ -118,14 +118,13 @@ SDK_LOCATION=$2
# Run ValidatesRunner tests on Google Cloud Dataflow service
echo ">>> RUNNING DATAFLOW RUNNER VALIDATESCONTAINER TEST"
-python setup.py nosetests \
- --attr ValidatesContainer \
- --nologcapture \
- --processes=1 \
- --process-timeout=900 \
- --with-xunitmp \
- --xunitmp-file=$XUNIT_FILE \
- --ignore-files '.*py3\d?\.py$' \
+pytest -o junit_suite_name=$IMAGE_NAME \
+ -m="it_validatescontainer" \
+ --no-print-logs \
Review comment:
This option is removed in future pytest versions. The replacement is
`--show-capture=no`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
