danthev commented on a change in pull request #14261:
URL: https://github.com/apache/beam/pull/14261#discussion_r627826022
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/firestore/RpcQosImpl.java
##########
@@ -204,7 +210,8 @@ public boolean awaitSafeToProceed(Instant instant) throws
InterruptedException {
state.checkActive();
Duration shouldThrottleRequest = at.shouldThrottleRequest(instant);
if (shouldThrottleRequest.compareTo(Duration.ZERO) > 0) {
- logger.info("Delaying request by {}ms",
shouldThrottleRequest.getMillis());
+ long throttleRequestMillis = shouldThrottleRequest.getMillis();
+ logger.debug("Delaying request by {}ms", throttleRequestMillis);
Review comment:
Is `throttlingMs` always reported, or does it hinge on that flag? As
long as a user can easily find out what's happening that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
