lostluck commented on a change in pull request #14748:
URL: https://github.com/apache/beam/pull/14748#discussion_r627850784
##########
File path: sdks/go/test/run_validatesrunner_tests.sh
##########
@@ -64,11 +64,11 @@ RUNNER=portable
TIMEOUT=1h
# Where to store integration test outputs.
-GCS_LOCATION=gs://temp-storage-for-end-to-end-tests
+GCS_LOCATION=gs://clouddfe-danoliveira/temp-storage-go-end-to-end-tests
Review comment:
I think we want to revert these changes, and use the apache-beam-testing
project instead.
##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
##########
@@ -128,6 +129,15 @@ func Translate(ctx context.Context, p *pipepb.Pipeline,
opts *JobOptions, worker
experiments = append(experiments,
"use_staged_dataflow_worker_jar")
}
+ for _, url := range opts.ArtifactURLs {
+ name := url[strings.LastIndexAny(url, "/")+1:]
+ jar := &df.Package{
Review comment:
nit: The artifacts aren't necessarily going to be Jars, as the
expansions aren't necessarily from Java. Maybe pkg which is reasonably generic?
##########
File path: sdks/go/test/run_validatesrunner_tests.sh
##########
@@ -314,7 +314,7 @@ if [[ "$JENKINS" == true ]]; then
|| TEST_EXIT_CODE=$? # don't fail fast here; clean up environment before
exiting
else
echo ">>> RUNNING $RUNNER VALIDATESRUNNER TESTS"
- go test -v ./sdks/go/test/integration/... $ARGS \
+ go test -run=TestXLang_Prefix -v ./sdks/go/test/integration/... $ARGS \
Review comment:
And we probably want to continue run all the tests ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
