robertwb commented on pull request #14490: URL: https://github.com/apache/beam/pull/14490#issuecomment-840771624
Thanks. I'm still not following why we need per-metric start times. And without start times, it seems the (payload-less) BiMap should just work which simplifies things even more. On Wed, May 12, 2021 at 8:47 PM Alex Amato ***@***.***> wrote: > i have split this up into two PRs, rather than 3. As the startTime logic > is much simpler now, and only done for the process wide MetricContainer. > Overall the whole thing is much smaller. PTAL > > (1) Change the way ShortIdMap works, > #14804 <https://github.com/apache/beam/pull/14804> > (2) Add process-wide metrics, and add the notion of startTime to a subset > of metrics. > #14805 <https://github.com/apache/beam/pull/14805> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/14490#issuecomment-840272513>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADWVAKMZQS67DO5YM5FCPTTNNDWNANCNFSM42UFLLAQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
