amaliujia commented on a change in pull request #14774:
URL: https://github.com/apache/beam/pull/14774#discussion_r632066200
##########
File path: sdks/java/testing/nexmark/build.gradle
##########
@@ -102,6 +109,39 @@ if (shouldProvideSpark) {
}
}
+def getNexmarkArgs = {
+ def nexmarkArgsStr = project.findProperty(nexmarkArgsProperty) ?: ""
+ def nexmarkArgsList = new ArrayList<String>()
+ Collections.addAll(nexmarkArgsList, nexmarkArgsStr.split())
+
+ if (isDataflowRunner) {
+ if (isDataflowRunnerV2) {
+
nexmarkArgsList.add("--experiments=beam_fn_api,use_unified_worker,use_runner_v2,shuffle_mode=appliance")
+ def sdkContainerImage = project.findProperty('sdkContainerImage') ?:
project(":runners:google-cloud-dataflow-java").dockerImageName
+ nexmarkArgsList.add("--sdkContainerImage=${sdkContainerImage}")
Review comment:
Is this line trying to provide images for runner v2? IIRC usually I use
two different flags to specify images for runner v2. Are you referring to other
v2 setup which use this flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
