chamikaramj commented on a change in pull request #14815:
URL: https://github.com/apache/beam/pull/14815#discussion_r632836587
##########
File path: sdks/python/apache_beam/transforms/display.py
##########
@@ -137,9 +137,12 @@ def create_payload(dd):
except ValueError:
# Skip if the display data is invalid.
return None
- if 'value' not in display_data_dict or 'label' not in display_data_dict:
+ if 'value' not in display_data_dict or (
Review comment:
Some existing transforms, sources etc. do not set a 'label'. So we'll
have to default to 'key' (which is always set) to not loose DisplayData for
some existing transforms.
Added a test and comments and refactored the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
