suztomo commented on a change in pull request #14474:
URL: https://github.com/apache/beam/pull/14474#discussion_r633667135
##########
File path:
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/fn/logging/BeamFnLoggingServiceTest.java
##########
@@ -131,23 +149,44 @@ public void
testMultipleClientsFailingIsHandledGracefullyByServer() throws Excep
tasks.add(
() -> {
CountDownLatch waitForTermination = new CountDownLatch(1);
+ LOG.info("Created latch for {}: {}", instructionId,
waitForTermination);
ManagedChannel channel =
InProcessChannelBuilder.forName(service.getApiServiceDescriptor().getUrl())
+ .executor(channelExecutor)
.build();
StreamObserver<BeamFnApi.LogEntry.List> outboundObserver =
BeamFnLoggingGrpc.newStub(channel)
.logging(
TestStreams.withOnNext(BeamFnLoggingServiceTest::discardMessage)
- .withOnError(waitForTermination::countDown)
+ .withOnError(
+ () -> {
+ waitForTermination.countDown();
+ LOG.info("Counted down latch {}",
waitForTermination);
+ })
.build());
outboundObserver.onNext(createLogsWithIds(instructionId,
-instructionId));
outboundObserver.onError(new RuntimeException("Client " +
instructionId));
Review comment:
onError is the last call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
