TheNeuralBit commented on a change in pull request #14656:
URL: https://github.com/apache/beam/pull/14656#discussion_r633786611
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -564,6 +564,14 @@ def dtype(self):
return self._expr.proxy().dtype
isin = frame_base._elementwise_method('isin', base=pd.DataFrame)
+ combine_first = frame_base._elementwise_method(
+ 'combine_first', base=pd.DataFrame)
+
+ combine = frame_base._proxy_method(
+ 'combine',
+ base=pd.DataFrame,
+ requires_partition_by=expressions.partitionings.Singleton(),
Review comment:
FYI I filed BEAM-12351 to track making this parallelizable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
