kw2542 commented on a change in pull request #14827:
URL: https://github.com/apache/beam/pull/14827#discussion_r634638069



##########
File path: runners/samza/job-server/build.gradle
##########
@@ -23,21 +25,84 @@ mainClassName = 
"org.apache.beam.runners.samza.SamzaJobServerDriver"
 
 applyJavaNature(
     automaticModuleName: 'org.apache.beam.runners.samza.jobserver',
+    archivesBaseName: project.hasProperty('archives_base_name') ? 
archives_base_name : archivesBaseName,
     validateShadowJar: false,
-
     exportJavadoc: false,
     shadowClosure: {
       append "reference.conf"
     },
 )
 
+def samzaRunnerProject = project.parent.path
+
+description = "Apache Beam :: Runners :: Samza :: Job Server"
+
+configurations {
+    validatesPortableRunner
+}
+
 dependencies {
-  compile project(":runners:samza")
-  permitUnusedDeclared project(":runners:samza")
+  compile project(samzaRunnerProject)
+  permitUnusedDeclared project(samzaRunnerProject)
   runtime group: "org.slf4j", name: "jcl-over-slf4j", version: 
dependencies.create(project.library.java.slf4j_api).getVersion()
+  validatesPortableRunner project(path: samzaRunnerProject, configuration: 
"testRuntime")
+  validatesPortableRunner project(path: ":sdks:java:core", configuration: 
"shadowTest")
+  validatesPortableRunner project(path: ":runners:core-java", configuration: 
"testRuntime")
+  validatesPortableRunner project(path: ":runners:portability:java", 
configuration: "testRuntime")
   runtime library.java.slf4j_simple
 }
 
 runShadow {
   args = []
 }
+
+def tempDir = File.createTempDir()
+def pipelineOptions = [
+        "--configOverride={\"job.non-logged.store.base.dir\":\"" + tempDir + 
"\"}"
+]
+createPortableValidatesRunnerTask(
+        name: "validatesPortableRunner",
+        jobServerDriver: "org.apache.beam.runners.samza.SamzaJobServerDriver",
+        jobServerConfig: 
"--job-host=localhost,--job-port=0,--artifact-port=0,--expansion-port=0",
+        testClasspathConfiguration: configurations.validatesPortableRunner,
+        numParallelTests: 1,
+        pipelineOpts: pipelineOptions,
+        environment: 
BeamModulePlugin.PortableValidatesRunnerConfiguration.Environment.EMBEDDED,
+        testCategories: {
+            includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+            // TODO: BEAM-12347
+            excludeCategories 'org.apache.beam.sdk.testing.UsesSideInputs'
+            // TODO: BEAM-12348
+            excludeCategories 'org.apache.beam.sdk.testing.UsesStatefulParDo'
+            // TODO: BEAM-12349
+            excludeCategories 'org.apache.beam.sdk.testing.UsesTimersInParDo'
+            // TODO: BEAM-12350
+            excludeCategories 
'org.apache.beam.sdk.testing.UsesAttemptedMetrics'
+
+            excludeCategories 
'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders'

Review comment:
       Do we have tickets for the following tests?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to