pabloem commented on a change in pull request #14745:
URL: https://github.com/apache/beam/pull/14745#discussion_r635463865
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_read_internal.py
##########
@@ -207,6 +206,10 @@ def process(self,
table_reference.datasetId,
table_reference.tableId)
+ bq._delete_dataset(
Review comment:
we should only delete the dataset if we were the ones creating it. Can
you add logic to bigquery_tools around `create_temporary_dataset` that lets us
know if we created the dtaset and thus should remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
