TheNeuralBit commented on a change in pull request #14309:
URL: https://github.com/apache/beam/pull/14309#discussion_r635479744
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -490,6 +518,7 @@ public Job getJob(JobReference jobRef, Sleeper sleeper,
BackOff backoff)
private DatasetServiceImpl(BigQueryOptions bqOptions) {
this.errorExtractor = new ApiErrorExtractor();
this.client = newBigQueryClient(bqOptions).build();
+ this.newWriteClient = newBigQueryWriteClient(bqOptions);
Review comment:
We're supposed to manage the lifecycle of this client and close it when
done. Since this code doesn't do that users see `SEVERE` errors (e.g.
BEAM-12359) whenever they use BigQueryIO. I filed BEAM-12365 for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
