ihji commented on a change in pull request #14801:
URL: https://github.com/apache/beam/pull/14801#discussion_r635546667



##########
File path: 
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkRunner.java
##########
@@ -74,7 +75,19 @@ protected FlinkRunner(FlinkPipelineOptions options) {
 
   @Override
   public PipelineResult run(Pipeline pipeline) {
-    
SplittableParDo.convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(pipeline);
+    // Portable flink only support SDF as read.

Review comment:
       A side question: does this mean that portable Flink doesn't currently 
support "use_deprecated_read" flag? What happens if we specify 
"use_deprecated_read" for portable Flink? Runtime error?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to