tjunderhill commented on a change in pull request #14840:
URL: https://github.com/apache/beam/pull/14840#discussion_r636434824
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ConfluentSchemaRegistryDeserializerProvider.java
##########
@@ -74,17 +75,23 @@
public static <T> ConfluentSchemaRegistryDeserializerProvider<T> of(
String schemaRegistryUrl, String subject) {
- return of(schemaRegistryUrl, subject, null);
+ return of(schemaRegistryUrl, subject, null, null);
}
public static <T> ConfluentSchemaRegistryDeserializerProvider<T> of(
- String schemaRegistryUrl, String subject, @Nullable Integer version) {
+ String schemaRegistryUrl,
+ String subject,
+ @Nullable Integer version,
+ @Nullable Map<String, ?> schemaRegistryConfigs) {
Review comment:
@aromanenko-dev I've added an additional signature, PTAL. thanks!
##########
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ConfluentSchemaRegistryDeserializerProvider.java
##########
@@ -60,7 +60,8 @@
SerializableFunction<Void, SchemaRegistryClient>
schemaRegistryClientProviderFn,
String schemaRegistryUrl,
String subject,
- @Nullable Integer version) {
+ @Nullable Integer version,
+ @Nullable Map<String, ?> schemaRegistryConfigs) {
Review comment:
@aromanenko-dev I've removed this augment from the constructor, PTAL.
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
