TheNeuralBit commented on a change in pull request #14845:
URL: https://github.com/apache/beam/pull/14845#discussion_r636514070



##########
File path: website/www/site/static/js/section-nav.js
##########
@@ -25,7 +25,8 @@ $(document).ready(function () {
             ACTIVE_CLASS: "active",
             EXPANDED_CLASS: "expanded",
             DESKTOP_BREAKPOINT: 1280,
-            OPEN_CLASS: "open"
+            OPEN_CLASS: "open",
+            LOCAL_HOST: "//localhost:1313"

Review comment:
       I'd prefer a solution that makes sure we use relative urls (drop the 
`//localhost:1313`) in the dev server. This is kind of brittle (e.g. what if 
you run your dev server on a different port?), and it would be on our 
production website.
   
   Do you know what we'd need to modify in the build.gradle for this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to