reuvenlax commented on pull request #14852: URL: https://github.com/apache/beam/pull/14852#issuecomment-846129530
@anantdamle I'm not completely sure I understand the use case. One comment I will make on the implementation, is that the existing GroupIntoBatches is very careful to mostly append to the BagState, and only to read from the BagState when it's ready to flush it. Your version reads the bag on every element, which can be very expensive (in fact it is O(n^2) in the number of elements). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
