boyuanzz commented on a change in pull request #14844:
URL: https://github.com/apache/beam/pull/14844#discussion_r637295863
##########
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2Runner.java
##########
@@ -145,7 +151,16 @@ public PipelineResult runTest(Pipeline pipeline) {
Twister2PipelineExecutionEnvironment env = new
Twister2PipelineExecutionEnvironment(options);
LOG.info("Translating pipeline to Twister2 program.");
pipeline.replaceAll(getDefaultOverrides());
+ // TODO(BEAM-10670): Use SDF read as default when we address performance
issue.
+ if (!ExperimentalOptions.hasExperiment(pipeline.getOptions(),
"use_sdf_read")) {
+ // Populate experiments directly to have Kafka use legacy read.
+ ExperimentalOptions.addExperiment(
+ pipeline.getOptions().as(ExperimentalOptions.class),
"beam_fn_api_use_deprecated_read");
Review comment:
I did change it in https://github.com/apache/beam/pull/14849/files but
it seems like this portion is not removed during cherry-pick.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
