pcoet commented on a change in pull request #14863:
URL: https://github.com/apache/beam/pull/14863#discussion_r637919597



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1871,12 +1871,15 @@ def clip(self, axis, **kwargs):
     """lower and upper must be :class:`DeferredSeries` instances, or constants.

Review comment:
       Are `lower` and `upper` arg names? I'm wondering if they should have 
backticks around them.

##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1871,12 +1871,15 @@ def clip(self, axis, **kwargs):
     """lower and upper must be :class:`DeferredSeries` instances, or constants.
     array-like arguments are not supported as they are order-sensitive."""

Review comment:
       "array-like arguments are not supported as they are order-sensitive." -> 
"Array-like arguments are not supported because they are order-sensitive."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to