mxm commented on a change in pull request #14671:
URL: https://github.com/apache/beam/pull/14671#discussion_r639604395
##########
File path: sdks/python/apache_beam/transforms/external.py
##########
@@ -319,25 +319,9 @@ def _service(self):
if isinstance(self._expansion_service, str):
channel_options = [("grpc.max_receive_message_length", -1),
("grpc.max_send_message_length", -1)]
- if hasattr(grpc, 'local_channel_credentials'):
- # Some environments may not support insecure channels. Hence use a
- # secure channel with local credentials here.
Review comment:
My concern is that we are breaking those environments by removing the
code here. I'm not a GRPC expert but if we are convinced that insecure channels
can always be used, then I'm ok with the change. Otherwise we probably need
some kind of fallback code which attempts a secure channel first, then falls
back to using an insecure channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
