iemejia commented on a change in pull request #14953:
URL: https://github.com/apache/beam/pull/14953#discussion_r646454566



##########
File path: runners/flink/flink_runner.gradle
##########
@@ -34,6 +34,11 @@ applyJavaNature(
 
 description = "Apache Beam :: Runners :: Flink $flink_version"
 
+dependencies {
+  implementation group: 'com.fasterxml.jackson.module', name: 
'jackson-module-jaxb-annotations', version: '2.12.3'

Review comment:
       Hello, thanks for contributing this fix! Which version of Flink (EMR) 
were you able to run with this fix (just out of curiosity).
   
   Can you put this on the main dependencies block
   
https://github.com/apache/beam/blob/92386d781b5d502c4ea47a0894b72ca57854553d/runners/flink/flink_runner.gradle#L176
   
   And can you use the default library definitions (and add the jsr310 one 
there).
   
https://github.com/apache/beam/blob/92386d781b5d502c4ea47a0894b72ca57854553d/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L580




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to