pabloem commented on a change in pull request #14690:
URL: https://github.com/apache/beam/pull/14690#discussion_r646831126
##########
File path: sdks/python/apache_beam/io/gcp/bigquery_test.py
##########
@@ -950,12 +943,10 @@ def store_callback(arg):
with open(file_name_2, 'w') as f:
json.dump(json_output, f)
- res = mock.Mock()
- res.insertErrors = []
Review comment:
because `insert_rows_json` returns a list of errors (empty when no
errors), and `client.tabledata.InsertAll` returns an object that contains the
list of errors within it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
