[GitHub] [beam] ibzib commented on a change in pull request #14955: [BEAM-11811] Disallow num_workers > max_num_workers for Go Dataflow runner

[GitBox]

ibzib commented on a change in pull request #14955:
URL: https://github.com/apache/beam/pull/14955#discussion_r646926411



##########
File path: sdks/go/pkg/beam/runners/dataflow/dataflowlib/job.go
##########
@@ -345,5 +346,14 @@ func validateWorkerSettings(ctx context.Context, opts 
*JobOptions) error {
                opts.WorkerZone = opts.Zone
                opts.Zone = ""
        }
+
+       numWorkers := opts.NumWorkers
+       maxNumWorkers := opts.MaxNumWorkers
+       if numWorkers < 0 {

Review comment:
       Should we should check maxNumWorkers >= 0 too?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org