boyuanzz commented on a change in pull request #14968:
URL: https://github.com/apache/beam/pull/14968#discussion_r647736613
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Watch.java
##########
@@ -955,11 +961,15 @@ public ProcessContinuation process(
return stop();
}
- if (BoundedWindow.TIMESTAMP_MAX_VALUE.equals(newResults.getWatermark()))
{
+ if (BoundedWindow.TIMESTAMP_MAX_VALUE.equals(computedWatermark)) {
LOG.info("{} - will stop polling, reached max timestamp.",
c.element());
return stop();
}
+ if (computedWatermark != null) {
Review comment:
We want to set the `watermark` for `watermarkEstimator` even when
`stop()` is returned, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
