TheNeuralBit edited a comment on pull request #14971: URL: https://github.com/apache/beam/pull/14971#issuecomment-857811062
Cool, thanks @zhoufek! > CC @TheNeuralBit since we recently discussed the issue of PubsubIO requiring a Java class and how we would improve that requirement for portability. Note we already have [ProtoDynamicMessageSchema](https://github.com/apache/beam/blob/master/sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoDynamicMessageSchema.java) which can make a `SchemaCoder<DynamicMesage>` given a proto descriptor. That combined with this PR could be a good avenue for making the pubsub TableProvider configurable via a proto descriptor rather than a proto class name. (CC: @apilloud @robinyqiu) EDIT: Oh I just looked at the code and this is already using ProtoDynamicMessageSchema, so it will just work with Beam schemas :) I think what we'd need to do to to use this approach in SQL and the PubSub TableProvider is implement the logic in the [ProtoPayloadSerializerProvider](https://github.com/apache/beam/blob/master/sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoPayloadSerializerProvider.java) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
