ibzib commented on a change in pull request #14942:
URL: https://github.com/apache/beam/pull/14942#discussion_r648654642
##########
File path:
runners/portability/java/src/main/java/org/apache/beam/runners/portability/ExternalWorkerService.java
##########
@@ -130,15 +131,13 @@ public void close() {}
* up-front and matches the running job. See {@link PipelineOptions}
for further details.
* </ul>
*/
- public static void main(String[] args) throws Exception {
- main(System::getenv);
- }
-
- public static void main(Function<String, String> environmentVarGetter)
throws Exception {
+ public static void main(String[] args) {
LOG.info("Starting external worker service");
- LOG.info("Pipeline options {}",
environmentVarGetter.apply(PIPELINE_OPTIONS_ENV_VAR));
- PipelineOptions options =
-
PipelineOptionsTranslation.fromJson(environmentVarGetter.apply(PIPELINE_OPTIONS_ENV_VAR));
+ final String optionsEnv =
+ checkArgumentNotNull(
+ System.getenv(PIPELINE_OPTIONS_ENV_VAR), "No pipeline options
provided.");
Review comment:
Make the error message actionable. Tell the user how to set
PIPELINE_OPTIONS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
