lukecwik commented on a change in pull request #14991:
URL: https://github.com/apache/beam/pull/14991#discussion_r651321236
##########
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/BeamFnDataReadRunnerTest.java
##########
@@ -178,7 +179,7 @@ public void testCreatingAndProcessingBeamFnDataReadRunner()
throws Exception {
null /* beamFnTimerClient */,
Review comment:
Your right that locking would be necessary since we wouldn't want to
have stale reads. In this case we are only overwriting data so it would be ok
but in other places reset may want to `read` the data and should lock
appropriately.
Would be good to document the concurrency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
