chamikaramj commented on a change in pull request #14713:
URL: https://github.com/apache/beam/pull/14713#discussion_r654669657
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java
##########
@@ -225,7 +233,7 @@
* number of entities per request may be lower when we flush for the end of
a bundle or if we hit
* {@link DatastoreV1.DATASTORE_BATCH_UPDATE_BYTES_LIMIT}.
*/
- @VisibleForTesting static final int DATASTORE_BATCH_UPDATE_ENTITIES_MIN = 10;
+ @VisibleForTesting static final int DATASTORE_BATCH_UPDATE_ENTITIES_MIN = 5;
Review comment:
Ditto. Note that this could potentially double the number of RPCs to
Datastore.
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java
##########
@@ -212,7 +220,7 @@
* <p>Testing has found that a batch of 200 entities will generally finish
within the timeout even
* in adverse conditions.
*/
- @VisibleForTesting static final int DATASTORE_BATCH_UPDATE_ENTITIES_START =
200;
+ @VisibleForTesting static final int DATASTORE_BATCH_UPDATE_ENTITIES_START =
50;
Review comment:
Why was this updated ? If 50 is a better number could you also update
the comment please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
