TheNeuralBit commented on pull request #13476:
URL: https://github.com/apache/beam/pull/13476#issuecomment-864327186


   > Is this still relevant?
   
   Yeah I already added back support for grouping by a Series in 
https://github.com/apache/beam/pull/14929
   
   I think this test still won't work actually, but I realized the issue 
exposed by this bug is in aligning a non-unique index. It's not anything 
inherently wrong with grouping by a series. I commented on BEAM-11393 with an 
explanation:
   
   > Note pandas also cannot handle this case when the grouping series has a 
different index. Pandas only works for this example because it can detect they 
have the same index and it recognizes it doesn't need to do anything to align 
them.
   > 
   > With better tracking of partitioning we may able to do the same sort of 
thing.
   
   Let's close this for now, but I'll keep BEAM-11393 open to track the align 
issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to