robertwb commented on a change in pull request #14805:
URL: https://github.com/apache/beam/pull/14805#discussion_r655739325
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##########
@@ -262,6 +265,8 @@ public static void main(
}
});
+ MetricsEnvironment.setProcessWideContainer(new MetricsContainerImpl());
Review comment:
My preference is to have the tests be non-idiomatic (e.g. you could have
a reset-process-container-for-test method) than have the "production" code be
non-idiomatic to accommodate tests. Having a setter doesn't prevent state from
leaking from test to test (though I guess it forces you to set it in at least
one test).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
