TheNeuralBit commented on a change in pull request #15062:
URL: https://github.com/apache/beam/pull/15062#discussion_r659010369



##########
File path: 
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/ProcessBundleHandler.java
##########
@@ -742,6 +749,7 @@ synchronized void setInstructionId(String instructionId) {
     }
 
     void reset() throws Exception {
+      this.instructionId = null;

Review comment:
       I think this broke Java PreCommit (it looks like this was submitted 
while precommits weren't running). Running `.gradlew 
:sdks:java:harness:spotbugsMain` on master right now yields:
   ```
   Inconsistent synchronization of 
org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor.instructionId;
 locked 66% of time                                                             
                                  
                                                                                
   
                                                                                
   
   Bug type IS2_INCONSISTENT_SYNC (click for details)                           
   
   In class 
org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor
   Field 
org.apache.beam.fn.harness.control.ProcessBundleHandler$BundleProcessor.instructionId
   Synchronized 66% of the time                                                 
   
   Unsynchronized access at ProcessBundleHandler.java:[line 752]                
   
   Synchronized access at ProcessBundleHandler.java:[line 748]                  
   
   Synchronized access at ProcessBundleHandler.java:[line 744] 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to