boyuanzz commented on a change in pull request #14811:
URL: https://github.com/apache/beam/pull/14811#discussion_r660267029
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java
##########
@@ -73,18 +74,16 @@ public static BatchSpannerRead create(
.apply(
"Generate Partitions",
ParDo.of(new GeneratePartitionsFn(getSpannerConfig(),
txView)).withSideInputs(txView))
- .apply("Shuffle partitions", Reshuffle.<Partition>viaRandomKey())
.apply(
"Read from Partitions",
ParDo.of(new ReadFromPartitionFn(getSpannerConfig(),
txView)).withSideInputs(txView));
}
@VisibleForTesting
- static class GeneratePartitionsFn extends DoFn<ReadOperation, Partition> {
+ static class GeneratePartitionsFn extends DoFn<ReadOperation,
List<Partition>> {
Review comment:
I have created https://issues.apache.org/jira/browse/BEAM-12522 for
tracking the sideinput with Splittable DoFn issue. I'm trying to work on a
quick fix, though I'm not sure whether the fix would be simple. In order to
unblock you, you can put a TODO(BEAM-12522) over the expansion saying that we
can do so when the sideinput is supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
