suztomo commented on a change in pull request #15098:
URL: https://github.com/apache/beam/pull/15098#discussion_r660989141
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_36_0.groovy
##########
@@ -161,8 +160,6 @@ class GrpcVendoring_1_36_0 {
"module-info.class",
"org/apache/commons/logging/**",
"org/apache/log/**",
- "org/apache/log4j/**",
- "org/apache/logging/log4j/**",
Review comment:
I confirmed that the resulting JAR does not contain log4j classes.
```
suztomo-macbookpro44% jar tf
vendor/grpc-1_36_0/build/libs/beam-vendor-grpc-1_36_0-0.2.jar |grep log4j
suztomo-macbookpro44%
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
