robertwb commented on a change in pull request #15099:
URL: https://github.com/apache/beam/pull/15099#discussion_r661013996
##########
File path: sdks/python/apache_beam/io/kafka.py
##########
@@ -96,8 +96,16 @@
('commit_offset_in_finalize', bool), ('timestamp_policy', str)])
-def default_io_expansion_service():
- return BeamJarExpansionService('sdks:java:io:expansion-service:shadowJar')
+def default_io_expansion_service(args = None):
+ extra_args = None
+ if args:
+ if type(args) != type({}):
Review comment:
`isinstance(args, dict)` otherwise even subclasses are excluded.
Generally Python uses duck typing, so as long as this offers an item method
(whether or not it's actually a dict) we should allow it through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
