rohdesamuel commented on a change in pull request #15097:
URL: https://github.com/apache/beam/pull/15097#discussion_r661721205



##########
File path: sdks/python/apache_beam/runners/interactive/recording_manager.py
##########
@@ -65,6 +65,13 @@ def var(self):
     """Returns the variable named that defined this PCollection."""
     return self._var
 
+  @property
+  def pcoll(self):
+    # type: () -> beam.pvalue.PCollection

Review comment:
       No, it shouldn't be. On line interactive_beam.py:469 there's an 
assertion that the variable is a PCollection before recording it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to