kw2542 commented on a change in pull request #15081:
URL: https://github.com/apache/beam/pull/15081#discussion_r661872721
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -79,13 +79,16 @@
private static final String dockerContainerImageOption =
"docker_container_image";
private static final String externalServiceAddressOption =
"external_service_address";
+ private static final String externalServiceExecutableOption =
"external_service_executable";
Review comment:
Good question, I had the same question for myself as well.
I ended up putting configurable executable because I noticed this is the
pattern in the Python external worker pool support [1]. However, I did notice
that in boot script [2] itself, it hard codes executable to be
`/opt/apache/beam/boot` when `--worker_pool` is specified.
I suppose we may follow the same pattern as Python to make external worker
pool itself configurable with executable but hard code `/opt/apache/beam/boot`
in boot itself, alternatively we may just hard code in external worker pool
itself. WDYT.
[1]
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/worker/worker_pool_main.py#L64
[2]
https://github.com/apache/beam/blob/master/sdks/python/container/boot.go#L91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
