mprashanthsagar commented on a change in pull request #14817:
URL: https://github.com/apache/beam/pull/14817#discussion_r662169023
##########
File path:
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java
##########
@@ -763,7 +751,7 @@ public void onSuccess(StorageObject response, HttpHeaders
httpHeaders)
@Override
public void onFailure(GoogleJsonError e, HttpHeaders httpHeaders)
throws IOException {
IOException ioException;
- if (errorExtractor.itemNotFound(e)) {
+ if (e.getCode() == HttpStatusCodes.STATUS_CODE_NOT_FOUND) {
Review comment:
`itemNotFound(e)` does a recursive check to find the exception, we could
have a `STATUS_CODE_NOT_FOUND` in the cause but not the root exception, Can we
retain usage of `errorExtractor.itemNotFound()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
